Swagger fixes for MultiVerb and ErrorDescription#1707
Merged
akshaymankar merged 6 commits intodevelopfrom Aug 19, 2021
Merged
Conversation
pcapriotti
force-pushed
the
pcapriotti/multiverb-combine-v2
branch
from
835aa11 to
94df354
Compare
Contributor
|
should this go into this release? |
Contributor
Author
I don't know. It's nothing particularly critical, just Swagger. It probably won't break anything else either. |
fisx
approved these changes
Aug 13, 2021
Contributor
|
Seems to work for me! Thanks for this PR!
|
Merged
10 tasks
This fixes an issue with MultiVerb error responses all having the same schema (the first one being declared).
The combineResponseSwagger function, introduced for `MultiVerb`, can also be used to implement the functionality of `CanThrow`. This PR reimplements the `HasSwagger` instance of `CanThrow` on top of `combineResponseSwagger`, leaving the functionality the same modulo the order of responses.
pcapriotti
force-pushed
the
pcapriotti/multiverb-combine-v2
branch
from
94df354 to
5588ccc
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a few issues with Swagger generation for
MultiVerbendpoints containingErrorDescriptionresponses. Namely:CanThrowandMultiVerb.These should all be fixed now. Here is the diff of the swagger JSON before and after the changes.
Checklist